Skip to content

Commit

Permalink
Update how-to-write-a-resolver doc
Browse files Browse the repository at this point in the history
The service account name and namespace for resolvers were the old one used
in the resolution repo.

Now both service account and namespace used for resolvers should be
`how-to-write-a-resolver`.

Signed-off-by: Chuang Wang <[email protected]>
  • Loading branch information
chuangw6 authored and tekton-robot committed Sep 22, 2022
1 parent 765ef04 commit ae9263f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions docs/how-to-write-a-resolver.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ along with some environment variables and other configuration that the
underlying `knative` framework expects. The deployed application is put
in the `tekton-pipelines` namespace and uses `ko` to build its
container image. Finally the `ServiceAccount` our deployment uses is
`resolver`, which is the default `ServiceAccount` shared by all
resolvers in the `tekton-pipelines` namespace.
`tekton-pipelines-resolvers`, which is the default `ServiceAccount` shared by all
resolvers in the `tekton-pipelines-resolvers` namespace.

The full configuration follows:

Expand All @@ -282,7 +282,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: demoresolver
namespace: tekton-pipelines
namespace: tekton-pipelines-resolvers
spec:
replicas: 1
selector:
Expand All @@ -302,7 +302,7 @@ spec:
app: demoresolver
topologyKey: kubernetes.io/hostname
weight: 100
serviceAccountName: resolver
serviceAccountName: tekton-pipelines-resolvers
containers:
- name: controller
image: ko://example.com/demoresolver/cmd/demoresolver
Expand Down
4 changes: 2 additions & 2 deletions docs/resolver-template/config/demo-resolver-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: demoresolver
namespace: tekton-pipelines
namespace: tekton-pipelines-resolvers
spec:
replicas: 1
selector:
Expand All @@ -35,7 +35,7 @@ spec:
app: demoresolver
topologyKey: kubernetes.io/hostname
weight: 100
serviceAccountName: resolver
serviceAccountName: tekton-pipelines-resolvers
containers:
- name: controller
image: ko://github.com/tektoncd/pipeline/docs/resolver-template/cmd/demoresolver
Expand Down

0 comments on commit ae9263f

Please sign in to comment.