Skip to content

Commit

Permalink
Bind webhook controller to a non priviliged port
Browse files Browse the repository at this point in the history
Running a server on 443 with a non priliged user would fail to start it.

Fixes #719
  • Loading branch information
chmouel authored and tekton-robot committed Apr 4, 2019
1 parent a669012 commit d719494
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func main() {
ServiceName: "tekton-pipelines-webhook",
DeploymentName: "tekton-pipelines-webhook",
Namespace: system.GetNamespace(),
Port: 443,
Port: 8443,
SecretName: "webhook-certs",
WebhookName: "webhook.tekton.dev",
}
Expand Down
4 changes: 2 additions & 2 deletions config/400-webhook-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ metadata:
spec:
ports:
- port: 443
targetPort: 443
targetPort: 8443
selector:
app: tekton-pipelines-webhook
app: tekton-pipelines-webhook

0 comments on commit d719494

Please sign in to comment.