-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Pipeline/Task to *Run label/annotation propagation 🥨
Before this fix, we are "forgetting" the Task and Pipeline metadata (Labels/Annotations) when using them in a Run (PipelineRun or TaskRun). It is however documented that those metadata get propagated to the generated Pod, and even the code after storing the Spec is written that way. Because we only store the spec, the second time we were reconciling the TaskRun or PipelineRun, we wouldn't fetch the referenced Task or Pipeline anymore, and thus, we would not propagate them. Signed-off-by: Vincent Demeester <[email protected]>
- Loading branch information
1 parent
ca7ffee
commit ee6ec91
Showing
4 changed files
with
47 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters