TaskRun and PipelineRun controller do not sync status on err from reconcile

[afrittoli]

Expected Behavior

When reconcile returns an error, there status, labels and annotations of the TaskRun/PipelineRun should still be sync'ed back.

Actual Behavior

In case of error, the error is returned, and no update happens.
There is only a little number of cases where this is relevant; nonetheless it should be fixed and unit test coverage added

Steps to Reproduce the Problem

1. pipeline/pkg/reconciler/v1alpha1/taskrun/taskrun.go

   Lines 124 to 128 in 7b06d63

   	// Reconcile this copy of the task run and then write back any status
   	// updates regardless of whether the reconciliation errored out.
   	if err := c.reconcile(ctx, tr); err != nil {
   	c.Logger.Errorf("Reconcile error: %v", err.Error())
   	return err

2. pipeline/pkg/reconciler/v1alpha1/pipelinerun/pipelinerun.go

   Lines 166 to 170 in 7b06d63

   	// Reconcile this copy of the pipelinerun and then write back any status or label
   	// updates regardless of whether the reconciliation errored out.
   	if err = c.reconcile(ctx, pr); err != nil {
   	c.Logger.Errorf("Reconcile error: %v", err.Error())
   	return err

Additional Info

[afrittoli]

/assign

[tekton-robot]

@afrittoli: GitHub didn't allow me to assign the following users: me.

Note that only tektoncd members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

/assign