Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRun support stop/wait status #2217

Closed
withlin opened this issue Mar 12, 2020 · 14 comments
Closed

TaskRun support stop/wait status #2217

withlin opened this issue Mar 12, 2020 · 14 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@withlin
Copy link
Member

withlin commented Mar 12, 2020

  1. Support stop/wait status,which will stop/wait the taskrun pod

idea:

1. user set task spec status to stop/wait staus
2. have a CRD find out which machine the current taskrun pod is on.
3. and then get running container id.
4. excute kill -STOP ${pid} ,which the pod will be  hold (use daemonset).
5. when set task status is reruning will excute  kill -CONT ${pid}

Do you have any better ideas?

@withlin
Copy link
Member Author

withlin commented Mar 12, 2020

/cc @vdemeester @sbwsg

@vdemeester
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2020
@ghost
Copy link

ghost commented Mar 12, 2020

It would be good to know a bit more about the intended use case for this feature. Why do you want it?

Is it to support something like #2159 ?

In general I think we would not want the Pod hanging around consuming resources while the TaskRun is waiting. Ideally when a TaskRun begins waiting its resources are released so that other tasks can be scheduled while it's sleeping. When the TaskRun is told to continue it would spin up a new Pod at the point where it left off.

The use cases for this behaviour (that I know of) are often systems that run for 24 hours or more. Examples include:

  • Manual Approvals that are performed by teams operating in different timezones
  • Approvals that trigger actions which are not allowed on the last day of the week and so must wait until the start of the following week
  • Canary analysis systems that observe metrics over a long period of time before making decisions
  • Global rollouts that span multiple days

In all of these cases it would be much better if the TaskRun released its resources while in a paused state.

@laik
Copy link

laik commented Mar 12, 2020

we test pod during taskRun, send a stop signal to the container system pid, at this time, the process stops and does not take up the load. I let this be an effective way to control the transfer of resources. If there is a rerun function, it is even better.

@laik
Copy link

laik commented Mar 12, 2020

/cc @sbwsg

@ghost
Copy link

ghost commented Mar 12, 2020

the process stops and does not take up the load

Curious about this - What state does the Pod enter into? Does Kubernetes release the resource quota it has set aside for the Pod?

@laik
Copy link

laik commented Mar 12, 2020

the process stops and does not take up the load

Curious about this - What state does the Pod enter into? Does Kubernetes release the resource quota it has set aside for the Pod?

the pod still running, but it doesn't work anymore, as we use fg/bg, my idea is to identify a paused state record in taskRun

@dibyom dibyom added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 12, 2020
@withlin
Copy link
Member Author

withlin commented Mar 20, 2020

/assign

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2020
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2021
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants