Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-pipeline release deletes knative-releases images #253

Closed
adrcunha opened this issue Nov 21, 2018 · 0 comments · Fixed by #256
Closed

build-pipeline release deletes knative-releases images #253

adrcunha opened this issue Nov 21, 2018 · 0 comments · Fixed by #256
Assignees
@adrcunha
Milestone
(0.3 Alpha releas...

Comments

@adrcunha
Copy link
Contributor

adrcunha commented Nov 21, 2018 •
edited
Loading

Proof:

https://storage.googleapis.com/knative-prow/logs/ci-knative-build-pipeline-release/1065160816732409857/build-log.txt

Root cause: https://github.com/knative/build-pipeline/blob/b28da6eccc8e055ac70f53df64d3d471de8c4c4e/test/e2e-tests.sh#L26

Path of doom:

  1. release script sets KO_DOCKER_REPO to the release GCR
  2. e2e tests run, DOCKER_REPO_OVERRIDE is set to KO_DOCKER_REPO no matter what.
    2.1. e2e tests (under the hood) see DOCKER_REPO_OVERRIDE set and use it for the tests
    2.2. e2e tests cleanup the GCR (DOCKER_REPO_OVERRIDE) at the end of the tests
adrcunha added a commit to knative/test-infra that referenced this issue Nov 21, 2018
@adrcunha
Disable ci-knative-build-pipeline-release
ca7807d 
Due to tektoncd/pipeline#253
adrcunha added a commit to knative/test-infra that referenced this issue Nov 21, 2018
@adrcunha
Temporarily remove ci-knative-build-pipeline-release
1f8c150 
Due to tektoncd/pipeline#253
@adrcunha adrcunha mentioned this issue Nov 21, 2018
Merged
@adrcunha adrcunha self-assigned this Nov 21, 2018
@bobcatfish bobcatfish added this to the 0.3 Alpha release milestone Nov 21, 2018
@adrcunha adrcunha mentioned this issue Nov 21, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Nov 21, 2018
@adrcunha @knative-prow-robot
Clean up e2e-tests.sh
a5881c7 
Remove unnecessary code and sync up the implementation with the other scripts in the other repos (serving, building, etc).

The removal of unconditionally overwriting `DOCKER_REPO_OVERRIDE` is the most important part of this PR, as it's not only unnecessary but also the fix for #253.

This PR also updates `test-infra` to include the latest fixes and features, while also updating the `Gopkg` files so the cleanup workaround in `update-deps.sh` is not necessary anymore.
knative-prow-robot pushed a commit to knative/test-infra that referenced this issue Nov 22, 2018
@adrcunha @knative-prow-robot
Temporarily remove ci-knative-build-pipeline-release (#271)
1aa31db 
Due to tektoncd/pipeline#253
@adrcunha adrcunha mentioned this issue Dec 5, 2018
Merged
knative-prow-robot pushed a commit to knative/test-infra that referenced this issue Dec 5, 2018
@adrcunha @knative-prow-robot
Add ci-knative-build-pipeline-release back (#295)
a73c2aa 
All the fixes are now in place, tektoncd/pipeline#253 is fixed.
@bobcatfish bobcatfish mentioned this issue Jun 13, 2019
Closed
chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this issue Dec 5, 2019
@openshift-merge-robot
Merge pull request tektoncd#253 from chmouel/fix-trianon-tianon
1e8b266 
Fix trianon => tianon 🤦‍♀️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrcunha adrcunha

Labels
None yet
Projects
None yet
Milestone
(0.3 Alpha release) Docs + Output Res...
Development

Successfully merging a pull request may close this issue.

Clean up e2e-tests.sh
2 participants
@bobcatfish @adrcunha