-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TaskRun creation fails, created from PipelineRun with TaskRunSpec #2682
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
jlpettersson
added a commit
to jlpettersson/pipeline
that referenced
this issue
May 23, 2020
TaskRunSpec set in PipelineRun is never propagated to new TaskRuns in `createTaskRun()`, they are only propagated to Condition-pods in `makeConditionCheckContainer()` This commit - Adds propagation to new TaskRuns - Also adds a unit test Fixes tektoncd#2682 /kind bug
3 tasks
jlpettersson
added a commit
to jlpettersson/pipeline
that referenced
this issue
May 23, 2020
TaskRunSpec set in PipelineRun is never propagated to new TaskRuns in `createTaskRun()`, they are only propagated to Condition-pods in `makeConditionCheckContainer()` This commit - Adds propagation to new TaskRuns - Also adds a unit test Fixes tektoncd#2682 /kind bug
@jlpettersson does the volume |
I created a PR as well. There was a missing piece in the implementation. |
tekton-robot
pushed a commit
that referenced
this issue
Jun 2, 2020
TaskRunSpec set in PipelineRun is never propagated to new TaskRuns in `createTaskRun()`, they are only propagated to Condition-pods in `makeConditionCheckContainer()` This commit - Adds propagation to new TaskRuns - Also adds a unit test Fixes #2682 /kind bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
That I can declare
TaskRunSpecs
in thePipelineRun
andTaskRun
with the given spec is created.Example:
As described in documentation about TaskRunSpec (However, there were errors in doc also, fixed in #2681)
Actual Behavior
TaskRun creation fails with:
/kind bug
The text was updated successfully, but these errors were encountered: