Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise our PodSecurityPolicy on CI #2792

Closed
vdemeester opened this issue Jun 9, 2020 · 13 comments
Closed

Exercise our PodSecurityPolicy on CI #2792

vdemeester opened this issue Jun 9, 2020 · 13 comments
Labels
area/test-infra Issues or PRs related to the testing infrastructure area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@vdemeester
Copy link
Member

We define a PodSecurityPolicy in our config/. But this PodSecurityPolicy is never exercised on the CI as it is not enabled by default, for the following reason:

Warning: If you enable the PodSecurityPolicy controller without first defining and authorizing any actual policies, no users, controllers, or service accounts can create or update Pods. If you are working with an existing cluster, you should define and authorize policies before enabling the controller.

This means we do not know if the PodSecurityPolicy is correctly setup and works as we expect (and/or as our user expects if they enable it on their cluster).

We can do the following:

  1. Keep the PodSecurityPolicy in config/ but then, we need to exercise it on our test infrastructure (at least for some tests).
    See Using PodSecurityPolicies on google cloud to see more in details on how to enable those. As of today, if we enable it, our tests suites should fail as the PodSecurityPolicy we define disallow running privileged containers/pods, and, well, we do use some during our test suites 🙃.

  2. Move the PodSecurityPolicy in a contrib/ folder, discussing what it is, what it does, how to use it. (here is why I say a contrib/ folder btw 😉)

/area testing
/area test-infra
/kind feature

/cc @bobcatfish @afrittoli @gabemontero

@tekton-robot tekton-robot added area/testing Issues or PRs related to testing area/test-infra Issues or PRs related to the testing infrastructure kind/feature Categorizes issue or PR as related to a new feature. labels Jun 9, 2020
@gabemontero
Copy link
Contributor

For reference, how you turn on an admission controller is here

PodSecurityPolicy in k8s docs: https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#podsecuritypolicy

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020
@vdemeester vdemeester changed the title Exericice our PodSecurityPolicy on CI Exercise our PodSecurityPolicy on CI Oct 1, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@vdemeester
Copy link
Member Author

Putting this in the "frozen" box as I really think we should exercise it, at least on a nightly.

/remove-lifecycle stale
/lifecycle frozem

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@vdemeester
Copy link
Member Author

/lifecycle frozen

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 5, 2021
@ghost
Copy link

ghost commented Oct 28, 2021

Given #4112 should we close this one?

@vdemeester
Copy link
Member Author

@sbwsg yes I would think so 👍🏼

@ghost
Copy link

ghost commented Oct 28, 2021

/close

@tekton-robot
Copy link
Collaborator

@sbwsg: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra Issues or PRs related to the testing infrastructure area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants