Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build tests should use combined build image and build Windows images #5177

Closed
abayer opened this issue Jul 20, 2022 · 3 comments · Fixed by #5178
Closed

CI build tests should use combined build image and build Windows images #5177

abayer opened this issue Jul 20, 2022 · 3 comments · Fixed by #5178
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@abayer
Copy link
Contributor

abayer commented Jul 20, 2022

As revealed by #5174, we're not actually build Windows images in pull-tekton-pipeline-build-tests, which resulted in code that can't compile on Windows slipping through in a PR. We should be setting Windows-supporting combined build images in ko_resolve in test/presubmit-tests.sh in the same sort of way we are in

# Combine Distroless with a Windows base image, used for the entrypoint image.
COMBINED_BASE_IMAGE=$(go run ./vendor/github.com/tektoncd/plumbing/cmd/combine/main.go \
ghcr.io/distroless/static \
mcr.microsoft.com/windows/nanoserver:ltsc2022 \
${CONTAINER_REGISTRY}/$(params.package)/combined-base-image:latest)
cat <<EOF > ${PROJECT_ROOT}/.ko.yaml
# This matches the value configured in .ko.yaml
defaultBaseImage: ghcr.io/distroless/static
baseImageOverrides:
# Use the combined base image for images that should include Windows support.
$(params.package)/cmd/entrypoint: ${COMBINED_BASE_IMAGE}
$(params.package)/cmd/nop: ${COMBINED_BASE_IMAGE}
$(params.package)/cmd/workingdirinit: ${COMBINED_BASE_IMAGE}
# This matches values configured in .ko.yaml
$(params.package)/cmd/git-init: ghcr.io/distroless/git
EOF

We can probably just use gcr.io/tekton-releases/github.com/tektoncd/pipeline/combined-base-image:latest for that combined base image, rather than generating a new one each time.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2022
@abayer
Copy link
Contributor Author

abayer commented Jul 20, 2022

I'm going to wait to open a PR until #5174 is dealt with, since the build would fail anyway.

abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jul 20, 2022
@abayer
Copy link
Contributor Author

abayer commented Jul 20, 2022

...ok, yeah, I didn't wait to open a PR. 🤷

abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jul 20, 2022
@vdemeester
Copy link
Member

cc @imjasonh

tekton-robot pushed a commit that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants