Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Tekton GCS release bucket & GCR repo #527

Closed
bobcatfish opened this issue Feb 20, 2019 · 1 comment
Closed

Create a Tekton GCS release bucket & GCR repo #527

bobcatfish opened this issue Feb 20, 2019 · 1 comment
Assignees
@dlorenc
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Milestone
Pipelines 0.2 🎉 🎉 🎉

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Feb 20, 2019 •
edited
Loading

Expected Behavior

Since we want to clearly distinguish Tekton Pipelines from the rest of Knative, and we are decoupling the release schedule, we should be releasing to a Tekton specific gcr repo and gcs bucket.

It should be clear:

  • What permissions are required to make releases to these locations
  • Who will have these permissions
  • How to obtain the permissions if you need them.

Actual Behavior

We currently release to gcr at gcr.io/knative-releases and the gcs bucket at knative-releases/build-pipeline. (see install.md)

Additional Info

Actually making the release automation use these endpoints is out of the scope of this issue, this is just about setting up the repo, bucket and permissions.
@bobcatfish bobcatfish added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 21, 2019
@bobcatfish bobcatfish added okr This is for some internal Google project tracking and removed okr This is for some internal Google project tracking labels Feb 21, 2019
@bobcatfish bobcatfish mentioned this issue Feb 21, 2019
Closed
@bobcatfish bobcatfish self-assigned this Feb 28, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Mar 8, 2019

We have this at gcr.io/tekton-releases and gs://tekton-releases.

@dlorenc dlorenc closed this as completed Mar 8, 2019
@bobcatfish bobcatfish assigned dlorenc and unassigned bobcatfish Mar 15, 2019
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 19, 2019
@bobcatfish
Use actual production bucket and registry by default (tektoncd#527)
d7bb27e
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 19, 2019
@bobcatfish
Use actual production bucket and registry by default (tektoncd#527)
6bb72e0
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 19, 2019
@bobcatfish
Use actual production bucket and registry by default (tektoncd#527)
0ebb46e
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 19, 2019
@bobcatfish
Use actual production bucket and registry by default (tektoncd#527)
d85285e
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 20, 2019
@bobcatfish
Use actual production bucket and registry by default (tektoncd#527)
4f36111
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 20, 2019
@bobcatfish
Add Task for publishing tekton pipeline images + yaml
a6630ef 
Add a `Task` which invokes `ko` to build and publish all images and yaml
config required for installing Tekton Pipelines.

This Task will:
* Build and publish the "base image" using Kaniko
* Generate a .ko.yaml
* Invoke ko to build/publish images and generate a release.yaml
* Parse the release.yaml for built images; ensuring that the expected
  images were built (and no more)
* Tag the built images with the correct version and also tag in all
  regions (us, asia, eu)

This should be the same functionality that could previously be seen in
https://github.com/tektoncd/pipeline/blob/master/hack/release.sh
(which used
https://github.com/knative/test-infra/blob/master/scripts/release.sh).
We can remove release.sh once we have completed tektoncd#530 as well.

Some functionality has been implemented in a python script, which has
its own tests. Since it is currently difficult to update the pull
request test logic to do additional things (such as run python unit
tests), I'm hoping we are okay with waiting until tektoncd#532 to add
automatic running of these tests).

Use actual production bucket and registry by default (tektoncd#527)

Fixes tektoncd#528
Fixes tektoncd#529
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Mar 20, 2019
@bobcatfish
Add Task for publishing tekton pipeline images + yaml
3da945d 
Add a `Task` which invokes `ko` to build and publish all images and yaml
config required for installing Tekton Pipelines.

This Task will:
* Build and publish the "base image" using Kaniko
* Generate a .ko.yaml
* Invoke ko to build/publish images and generate a release.yaml
* Parse the release.yaml for built images; ensuring that the expected
  images were built (and no more)
* Tag the built images with the correct version and also tag in all
  regions (us, asia, eu)

This should be the same functionality that could previously be seen in
https://github.com/tektoncd/pipeline/blob/master/hack/release.sh
(which used
https://github.com/knative/test-infra/blob/master/scripts/release.sh).
We can remove release.sh once we have completed tektoncd#530 as well.

Some functionality has been implemented in a python script, which has
its own tests. Since it is currently difficult to update the pull
request test logic to do additional things (such as run python unit
tests), I'm hoping we are okay with waiting until tektoncd#532 to add
automatic running of these tests).

Use actual production bucket and registry by default (tektoncd#527)

Fixes tektoncd#528
Fixes tektoncd#529
tekton-robot pushed a commit that referenced this issue Mar 22, 2019
@bobcatfish @tekton-robot
Add Task for publishing tekton pipeline images + yaml
5cf3083 
Add a `Task` which invokes `ko` to build and publish all images and yaml
config required for installing Tekton Pipelines.

This Task will:
* Build and publish the "base image" using Kaniko
* Generate a .ko.yaml
* Invoke ko to build/publish images and generate a release.yaml
* Parse the release.yaml for built images; ensuring that the expected
  images were built (and no more)
* Tag the built images with the correct version and also tag in all
  regions (us, asia, eu)

This should be the same functionality that could previously be seen in
https://github.com/tektoncd/pipeline/blob/master/hack/release.sh
(which used
https://github.com/knative/test-infra/blob/master/scripts/release.sh).
We can remove release.sh once we have completed #530 as well.

Some functionality has been implemented in a python script, which has
its own tests. Since it is currently difficult to update the pull
request test logic to do additional things (such as run python unit
tests), I'm hoping we are okay with waiting until #532 to add
automatic running of these tests).

Use actual production bucket and registry by default (#527)

Fixes #528
Fixes #529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlorenc dlorenc

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
Pipelines 0.2 🎉 🎉 🎉
Development

No branches or pull requests
2 participants
@bobcatfish @dlorenc