Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to remove resources from the codebase #5785

Closed
JeromeJu opened this issue Nov 22, 2022 · 2 comments
Closed

Decide whether to remove resources from the codebase #5785

JeromeJu opened this issue Nov 22, 2022 · 2 comments

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 22, 2022

This issue is opened for further discussion about whether we should remove the resources-related fields and respective supports. The current approach we went for includes keeping the deprecated resources and its related fields where it has been serialized in the conversions. However, this is brought up to discussion in the PR when releasing V1 CRD.

The goal of this issue is to make sure that the V1 release can move forward after reaching a consensus on whether we should keep the current route for keeping the resources related fields.

Thanks to @pritidesai @vdemeester and @lbernick for the discussion at the v1-CRD-release PR #5579 (comment)_

Related discussions:

@JeromeJu JeromeJu mentioned this issue Nov 22, 2022
6 tasks
@JeromeJu
Copy link
Member Author

JeromeJu commented Nov 28, 2022

AI:

  • To make sure there are Validations on the annotations when converting down from v1 to v1beta1

To be put in code review:
To have documentations on the conversion of annotations, and about how it will get dropped later

@JeromeJu JeromeJu changed the title Removal of resources from the codebase Decide wether to remove resources from the codebase Nov 28, 2022
@JeromeJu JeromeJu changed the title Decide wether to remove resources from the codebase Decide whether to remove resources from the codebase Nov 28, 2022
@JeromeJu
Copy link
Member Author

Closing as the consensus is reached during WG and resources will be kept supported in the code base while being serialized into annotations when converted to v1.

#5805 is created as a follow up issue of the AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant