Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 CRD release #5579

Merged
merged 2 commits into from
Dec 15, 2022
Merged

V1 CRD release #5579

merged 2 commits into from
Dec 15, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Sep 28, 2022

Changes

This commit releases the v1 pipeline CRDs including task, taskrun, pipeline and
piplinerun by the following:

The second commit adds the integration test for v1 CRD:

  • This covers all the deprecated fields from v1beta1.
  • It first creates v1beta1 CRD with v1beta1Client and requests it by v1client,
    and then creates v1 CRD with v1Client and requests it by v1beta1client to
    compare if the conversion webhook.

Part i & ii of #5541
Fixes: #5627

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Releases v1 CRD for task, taskrun, pipeline and pipelinerun. Served v1 CRDs are included in this release for users as a preview, and also for users to start preparing for the migration. v1 is served but CLI, Dashboard, Chains etc support won't be available until the following release. v1 will be the official version starting with the next release when it has been released as the storage version.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2022
@JeromeJu JeromeJu marked this pull request as draft September 28, 2022 19:48
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2022
@lbernick lbernick self-assigned this Sep 29, 2022
@JeromeJu JeromeJu marked this pull request as ready for review September 29, 2022 16:42
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@JeromeJu JeromeJu changed the title Create example tests for the release of v1 pipeline CRD V1 CRD release Sep 29, 2022
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please move the v1 migration docs into the docs folder?

examples/v1/pipelineruns/pipelinerun-with-final-tasks.yaml Outdated Show resolved Hide resolved
examples/v1/pipelineruns/pipelinerun.yaml Outdated Show resolved Hide resolved
examples/v1/pipelineruns/pipelinerun.yaml Outdated Show resolved Hide resolved
@lbernick
Copy link
Member

Also, this PR needs a release note

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Sep 30, 2022
1 Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@lbernick
Copy link
Member

lbernick commented Sep 30, 2022

@abayer FYI since the only thing blocking this PR is #5515 -- you might need to coordinate with Jerome here

@lbernick lbernick mentioned this pull request Oct 3, 2022
7 tasks
@lbernick lbernick added this to the Pipelines v0.41 milestone Oct 4, 2022
@JeromeJu JeromeJu force-pushed the v1-release branch 2 times, most recently from efa0da9 to 56bae18 Compare October 4, 2022 17:43
@vdemeester
Copy link
Member

Are we sure 100% we want v1 API in 0.41 ? Because as soon as we publish them, we will not be able to change it that much. And we should probably agree on things like Tekton Pipeline V1 policy prior to getting this in.

@vdemeester
Copy link
Member

/hold

@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 8, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2022
@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 8, 2022

/retest
Codebase not updated in Prow for the fix.

@JeromeJu JeromeJu force-pushed the v1-release branch 5 times, most recently from fa55a54 to d5c57fb Compare December 8, 2022 21:47
@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 8, 2022

/retest

@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 8, 2022

This PR is ready for a final review PTAL @tektoncd/core-maintainers 🙏
cc @afrittoli @abayer @dibyom @lbernick @pritidesai @vdemeester

Previously this is on hold for adding the Status fields conversions and these changes are updated and added in the respective conversion integration test cases at test/conversion_test.go.

@dibyom
Copy link
Member

dibyom commented Dec 9, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, chitrangpatel, dibyom, lbernick, XinruZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,dibyom,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2022
This commit adds the examples test for the v1 CRD. It sets the `served` fields of the CRDs to true.
This commit adds the integration test for v1 CRD upgraded from v1beta1 and tests the conversion by
first creating the expected v1beta1 CRD and then requesting the v1 version of it for comparison.
@dibyom
Copy link
Member

dibyom commented Dec 15, 2022

/lgtm

I think the last outstanding issue was around errors while handling status conversions - I verified that the both v1beta1 and v1 example pipelineruns run successfully and the status is displayed when using kubectl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for upgrading API versions