ChildReference -> actual object status helper functions aren't handling v1alpha1.Runs. #5933
Comments
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this issue
Jan 3, 2023
… and Runs fixes tektoncd#5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
7 tasks
tekton-robot
pushed a commit
that referenced
this issue
Jan 4, 2023
… and Runs fixes #5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Jan 4, 2023
… and Runs fixes tektoncd#5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
JeromeJu
pushed a commit
to JeromeJu/pipeline
that referenced
this issue
Jan 4, 2023
… and Runs fixes tektoncd#5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Jan 5, 2023
… and Runs fixes #5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I added support for
CustomRuns to the reconciler, I switched the logic inpkg/statusto useCustomRuninstead ofRun...but we want to support bothCustomRuns andRuns, withRuns still the default for now. So we need to add back in support forv1alpha1.Runin the relevant functions.This should get backported to v0.43.x.
cc @piyush-garg @vinamra28 since this is what's causing the tests in tektoncd/cli#1838 to fail
/kind bug
The text was updated successfully, but these errors were encountered: