-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surfacing of actual Termination Reason in Step Status #7223
Comments
/good-first-issue |
@chitrangpatel: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @chitrangpatel , Recently a Termination Reason pipeline/pkg/entrypoint/entrypointer.go Lines 195 to 201 in a7d15ce
Termination Reason: Canceled Should this reason also be added to the table? |
Yes, it should @chengjoey! I aded it to the table. Thanks 🙏 |
@shankarpentyala07 PTAL at the proposed changes to surface actual termination reason, thanks! |
/assign @shankarpentyala07 |
Hey @shankarpentyala07! I just wanted to check if you are actively working in this issue. If not I would be happy to help with this. Thanks a lot! 😄 |
Hi @renzodavid9 ,Thanks for checking. |
/unassign @shankarpentyala07 |
Hi @renzodavid9 - I have unassigned , please proceed. |
/assign |
Got it! Thanks @shankarpentyala07! I just assigned this |
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this.
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this. Co-authored-by: JeromeJu <[email protected]>
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this. Co-authored-by: JeromeJu <[email protected]>
Related with tektoncd#7223. To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We evaluated changing the container `reason` directly, but looks like k8s doesn't allow this. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with tektoncd#7539 and tektoncd#7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Related with #7539 and #7223 To report specific Steps termination reasons we need to know why its continer finished; we use the termination message to store a new "state" with this information. We are adding a new field to store this information per step. Co-authored-by: JeromeJu <[email protected]> Co-authored-by: Chitrang Patel <[email protected]>
Current behaviour
Currently, Tekton only reports
Completed
andError
asTerminated Reasons
inStep
status after theStep
terminates.The status
Error
is also applied to theSteps
if it "times out" or if the previousStep
failed and caused this to be "skipped".Likewise, the status
Completed
is applied to theStep
if it actually "completed with exit code 0" or if theStep
actually errored but theTask
setonError: continue
for thatStep
.The table below summarizes it.
Errored
but ignored sinceonError
was set tocontinue
.This makes getting true visibility into the Steps challenging since the Termination reasons
Completed
andError
could mean different things.Proposed behaviour
In order to get better visibility into what's happening in the underlying
Steps
, here is the proposed changes to the Termination Reason in theStep
status.Errored
but ignored sinceonError
was set tocontinue
./kind bug
The text was updated successfully, but these errors were encountered: