Use moar builders in tests 👷♀️ #1044
Conversation
In tektoncd#1043 @EliZucker updated the package names of the v1alpha1 tests to be `v1alpha1_test`. He did this b/c he wanted to use a function he was adding to the builder test package for the work he is doing in tektoncd#207, but this has the nice side effect of making it so that we can use more builders in these tests! (We couldn't before b/c the builders themselves have to import and use `v1alpha1`). This commit updates many of these tests to use builders.
tekton-robot
added
approved
googlebot
added
the
cla: yes
|
|
|
@vdemeester: Bad category. Please see https://api.thecatapi.com/api/categories/list In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
aw no space cat for me :( the /meow plugin can't seem to handle when anything follows it on newlines! 😅 i will do my own space cat: /meow space |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
In #1043 @EliZucker updated the package names of the v1alpha1 tests to
be
v1alpha1_test. He did this b/c he wanted to use a function he wasadding to the builder test package for the work he is doing in #207, but
this has the nice side effect of making it so that we can use more
builders in these tests! (We couldn't before b/c the builders themselves
have to import and use
v1alpha1). This commit updates many of thesetests to use builders.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes