Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and work around timeout handler data races #1308

Merged
merged 3 commits into from
Sep 15, 2019
Merged

Fix and work around timeout handler data races #1308

merged 3 commits into from
Sep 15, 2019

Commits on Sep 13, 2019

  1. Remove unused function 👻 

    The function `GetLogMessages` isn't used anywhere. I had tried to remove
it to see if it was causing the data race in tektoncd#1124 - it _isnt_ but still
it's not being used anywhere so why not remove :)
    @bobcatfish
    bobcatfish committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    71bd601 View commit details
    Browse the repository at this point in the history

  2. Remove logging from timeout handler ✏️ 

    Logging in the timeout handler was added as part of tektoncd#731 cuz it helped
us debug when the timeout handler didn't work as expected. Unfortunately
it looks like the logger we're using can't be used in multiple go
routines (uber-go/zap#99 may be related).
Removing this logging to fix tektoncd#1124, hopefully can find a safe way to add
logging back in tektoncd#1307.
    @bobcatfish
    bobcatfish committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    1c89311 View commit details
    Browse the repository at this point in the history

  3. Make GetRunKey threadsafe 🔒 

    GetRunKey is accessed in goroutines via the timeout_handler; accessing
attributes of an object in a goroutine is not threadsafe. This is used
as a key in a map, so for now replacing this with a value that should be
unique but also threadsafe to fix tektoncd#1124
    @bobcatfish
    bobcatfish committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    0e9a727 View commit details
    Browse the repository at this point in the history