Remove test/logs helper binary in favor of tkn ⚓ #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tkn` is already released and can display logs as much as this helper. So let's remove this code and use a released version of tkn instead. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
/lgtm niiiice |
2 tasks
|
Depends on tektoncd/plumbing#83 |
vdemeester
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
tektoncd/plumbing#83 is in, now needs to build, publish and update the image in prow 😛 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
afrittoli
added a commit
to afrittoli/plumbing
that referenced
this pull request
Oct 24, 2019
Similar to tektoncd/pipeline#1414, now that tkn is in the test-runner image, drop the custom logger in favour of tkn {} logs.
2 tasks
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Oct 24, 2019
Similar to tektoncd/pipeline#1414, now that tkn is in the test-runner image, drop the custom logger in favour of tkn {} logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tknis already released and can display logs as much as thishelper. So let's remove this code and use a released version of tkn
instead.
/cc @bobcatfish @afrittoli
How do you prefer to install
tknbinary in the test image ?tektoncd/plumbing; this would maketknavailable for all the projects 😉Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.