-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix little typo #1444
Fix little typo #1444
Conversation
Hi @tomfrenken. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Should be good to go once the CLA is signed!
@googlebot I signed it! |
/lgtm |
@googlebot I signed it! |
/approve cancel |
/approve |
/approve cancel |
@googlebot I signed it! |
@tomfrenken i'm not sure exactly how the CLA bot works but right now when I tell it to scan this PR I get the following error message:
When you signed the CLA did you use this email address? It's the email used in the author line of your commit. |
Thanks @sbwsg - I was just chatting with @tomfrenken on slack about the same issue - the email address in the commit message needs to be fixed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Alright, thank y'all for your help with my Google bot odyssey - should work now, just needs the lgtm label back |
/lgtm |
No description provided.