Remove cmd/bash image #1503
Merged
Remove cmd/bash image #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
imjasonh
force-pushed
the
nobash2
branch
3 times, most recently
from
1b31f9d
to
d2284ea
Compare
|
/lgtm |
imjasonh
force-pushed
the
nobash2
branch
2 times, most recently
from
4e6ed1d
to
af19e0c
Compare
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Oct 31, 2019
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Oct 31, 2019
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
This image was previously responsible for invoking some specified bash commands, typically cp and mkdir, but occasionally more exotic things like setting up executable files for step scripts. Ultimately this image existed merely to pass args to "sh -c" (not even bash!), which can be done directly. This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `sh` (and `cp`, `mkdir`, `cat`, the usual suspects).
|
The following is the coverage report on pkg/.
|
|
You probably have to update the release task since this removes an image from our release process. (See the checklist of stuff that's easy to miss) |
vdemeester
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
cc @afrittoli (we may need to update something in plumbing for the time being ?
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Oct 31, 2019
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Oct 31, 2019
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
vdemeester
added a commit
to vdemeester/tektoncd-plumbing
that referenced
this pull request
Oct 31, 2019
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <[email protected]>
2 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Oct 31, 2019
Based on #1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
vdemeester
added a commit
to vdemeester/tektoncd-plumbing
that referenced
this pull request
Nov 4, 2019
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Nov 4, 2019
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This image was previously responsible for invoking some specified bash
commands, typically cp and mkdir, but occasionally more exotic things
like setting up executable files for step scripts.
Ultimately this image existed merely to pass args to "sh -c" (not even
bash!), which can be done directly.
This change should be entirely transparent to end users.
Operators can override the image being used if they so desire, to point
to any image that contains
sh(andcp,mkdir,cat, the usualsuspects).
Fixes #1446 with extreme prejudice
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes