Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kanikotest skip on environment using scc #1563

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Nov 13, 2019

The TestKanikoTaskRun needs priviledged access or
needs to be run as root user on platform like
OpenShift. This will add a flag which can be
passed in go test and test can be skipped

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

The TestKanikoTaskRun needs priviledged access or
needs to be run as root user on platform like
OpenShift. This will add a flag which can be
passed in go test and test can be skipped
@tekton-robot tekton-robot requested review from imjasonh and a user November 13, 2019 14:37
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 13, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@piyush-garg
Copy link
Contributor Author

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 224401c into tektoncd:master Nov 13, 2019
tekton-robot pushed a commit that referenced this pull request Mar 24, 2020
PR #1563 adds logic to skip TestKanikoTaskRun test when a flag is set as it requires to run containers with root user.
The registration of the flag was however missing. This aims to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants