-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated serviceAccount field from *Run 🌳 #1618
Remove deprecated serviceAccount field from *Run 🌳 #1618
Conversation
The following is the coverage report on pkg/.
|
dc5b2a8
to
0504676
Compare
The following is the coverage report on pkg/.
|
@vdemeester rebase? 👼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
/lgtm
oh boy.. I need to rebase indeed 😂 |
This removes the deprecated `serviceAccount` field from TaskRun and PipelineRun in favor of the newly added `serviceAccountName` (in previous release) to match more closely the kubernetes API. Signed-off-by: Vincent Demeester <[email protected]>
0504676
to
8c3d24c
Compare
The following is the coverage report on pkg/.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woot thanks @vdemeester !! |
Changes
This removes the deprecated
serviceAccount
field from TaskRun andPipelineRun in favor of the newly added
serviceAccountName
(inprevious release) to match more closely the kubernetes API.
Closes #1219
Signed-off-by: Vincent Demeester [email protected]
/cc @bobcatfish @afrittoli
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes