Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pipeline to v1alpha2 🎋 #1864

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Add Pipeline to v1alpha2 🎋 #1864

merged 1 commit into from
Jan 22, 2020

Conversation

vdemeester
Copy link
Member

Changes

This port Pipeline spec to v1alpha2, nothing really change from v1alpha1.

With this one, we are getting closer to all structs ported to v1alpha2 👼 (only PipelineRun is missing) —

Signed-off-by: Vincent Demeester [email protected]

/cc @bobcatfish @dibyom @sbwsg

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@tekton-robot tekton-robot requested review from bobcatfish, dibyom and a user January 13, 2020 18:00
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 13, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 13, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/pipeline_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/pipeline_types.go Do not exist 78.6%
pkg/apis/pipeline/v1alpha2/pipeline_validation.go Do not exist 93.9%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/pipeline_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/pipeline_types.go Do not exist 82.4%
pkg/apis/pipeline/v1alpha2/pipeline_validation.go Do not exist 93.9%

@chmouel
Copy link
Member

chmouel commented Jan 14, 2020

/lgtm

Looking Good! 🤙🏽

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/pipeline_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/pipeline_types.go Do not exist 82.4%
pkg/apis/pipeline/v1alpha2/pipeline_validation.go Do not exist 94.4%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/pipeline_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/pipeline_types.go Do not exist 82.4%
pkg/apis/pipeline/v1alpha2/pipeline_validation.go Do not exist 94.4%

@vdemeester
Add Pipeline to v1alpha2 🎋
731a994 
This port Pipeline spec to v1alpha2, nothing really change from v1alpha1.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/pipeline_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/pipeline_types.go Do not exist 82.4%
pkg/apis/pipeline/v1alpha2/pipeline_validation.go Do not exist 94.4%

@ghost
Copy link

ghost commented Jan 21, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Jan 21, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@abayer
Copy link
Contributor

abayer commented Jan 22, 2020

/lgtm

@abayer
Copy link
Contributor

abayer commented Jan 22, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit 3f2f350 into tektoncd:master Jan 22, 2020
@vdemeester vdemeester deleted the v1alpha2-pipeline branch January 22, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@chmouel chmouel

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @tekton-robot @chmouel @abayer @googlebot