Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-containerregistry to latest version #1882

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 16, 2020

Changes

This allows to fix the OpenShit + GCP bug (#1742) and it also removes the
dependency on k8s.io/kubernetes that is a pain when upgrading to new
kubernetes version.

See google/go-containerregistry#649

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and [backwards incompatible changes](http #1742s://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-incompatible-changes) must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 16, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2020
k8s.io/apimachinery v0.0.0
k8s.io/client-go v0.0.0
k8s.io/code-generator v0.0.0
k8s.io/api v0.17.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't make go not changing thoses (go mod tidy & co always add this one…) It doesn't matter as they are replaced.. it's just a pain…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we have to keep replacing them manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think so… I am hoping we won't, I need to try something out.. but I think until we bump to 1.15 (v0.15) or 1.17, we will still need the replace (but I might be wrong, I'll try that when I bump to 1.15 👼 )

@vdemeester
Copy link
Member Author

/hold

Something is fishy though.. I don't get why there is docker/docker, containerd/containerd, … in the vendor folder (and not in the go.mod...)…

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@vdemeester
Copy link
Member Author

oups.. I need to add a LICENSE to my repository…

@vdemeester
Copy link
Member Author

# github.com/docker/docker/api/types
github.com/tektoncd/pipeline/pkg/pod
github.com/google/go-containerregistry/pkg/authn/k8schain
github.com/vdemeester/k8s-pkg-credentialprovider
github.com/docker/docker/api/types

Interesting.. which version did it take…

This allows to fix the OpenShit + GCP bug **and** it also removes the
dependency on `k8s.io/kubernetes` that is a pain when upgrading to new
kubernetes version.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
k8s.io/apimachinery v0.0.0
k8s.io/client-go v0.0.0
k8s.io/code-generator v0.0.0
k8s.io/api v0.17.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we have to keep replacing them manually?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@dibyom
Copy link
Member

dibyom commented Jan 16, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@tekton-robot tekton-robot merged commit 530f084 into tektoncd:master Jan 16, 2020
@vdemeester vdemeester deleted the bump-go-containerregistry branch January 16, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants