Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename passedConstraints to providedBy #245

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

nader-ziada
Copy link
Member

Fixes: #137

Since the "passedConstraint" flag is for indicating that the task should use that input resource coming from the task(s) in the list, "providedBy" conveys the meaning better

/cc @bobcatfish

 - Issue tektoncd#137
 - since the "passedConstraint" flag is for indicating that the task should
 use that input resource coming from the task(s) in the list,
 "providedBy" conveys the meaning better
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2018
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pivotal-nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pivotal-nader-ziada]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@bobcatfish
Copy link
Collaborator

Nice! Looks great, I think this will be clearer :D

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2018
@knative-prow-robot knative-prow-robot merged commit 0d6a3a2 into tektoncd:master Nov 20, 2018
Copy link
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nader-ziada nader-ziada deleted the providedby branch November 29, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants