Omit potential NotFound when cleaning up the Affinity Assistant

[jlpettersson]

Changes

The PipelineRun reconciler cleanup the affinity assistant
when the PipelineRun is completed. If the cleanup-function
is called more than once, the DELETE request will return
a NotFound response. It does not make sense to return NotFound
responses as an error, since this is what we want to achieve.

Closes #3205
/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Omit potential NotFound events when cleaning up the Affinity Assistant

[bobcatfish]

Thanks for fixing this @jlpettersson !

It seems like cleanupAffinityAssistants is called regardless of whether or not the affinity assistant is enabled, is it possible to avoid calling it when the assistant is disabled?

Side note if at all possible let's move toward not having functions on the reconciler and having a separate affinity assistant package we can unit test (if we make more updates here)

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bobcatfish,sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abudavis]

Any ideas when the fix for this would be presented on the Pipeline Operator on Openshift 4.5?

[bharathvenkatrajan]

@abudavis I am having the same issue on the openshift pipeline operator 1.1.1 on Openshift 4.5. Is there a workaround for this?

[vdemeester]

@abudavis @bharathvenkatrajan this will be available in OpenShift Pipelines 1.2 (released in a few weeks).