Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for Windows #4139

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Add e2e tests for Windows #4139

merged 2 commits into from
Aug 11, 2021

Conversation

aiden-deloryn
Copy link
Contributor

Changes

Two new tests have been added for Windows TaskRuns for testing
success and failure states.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@aiden-deloryn
Add e2e tests for Windows
33f737e 
Two new tests have been added for Windows TaskRuns for testing
success and failure states.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 5, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2021
@tekton-robot
Copy link
Collaborator

Hi @aiden-deloryn. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2021
@aiden-deloryn
Copy link
Contributor Author

/assign @dibyom

@dibyom
Copy link
Member

dibyom commented Aug 6, 2021

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2021
dibyom
dibyom reviewed Aug 6, 2021
View reviewed changes
test/windows_test.go Outdated
Name: "unnamed-0",
ContainerName: "step-unnamed-0",
}}
ignoreTerminatedFields := cmpopts.IgnoreFields(corev1.ContainerStateTerminated{}, "StartedAt", "FinishedAt", "ContainerID")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: these two ingnoreField variables are the same across both tests...maybe extract them to a var at the top of the file and reuse?

imjasonh
imjasonh reviewed Aug 7, 2021
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some docs in a README about how to run windows tests, assuming running against a cluster with Windows nodes? Eventually we'll make this easier but some docs for now would be nice.

test/windows_test.go Outdated
taskRun := &v1beta1.TaskRun{
ObjectMeta: metav1.ObjectMeta{Name: taskRunName, Namespace: namespace},
Spec: v1beta1.TaskRunSpec{
TaskRef: &v1beta1.TaskRef{Name: taskName},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can skip creating the Task then the TaskRun by specifying the taskSpec. This should be slightly faster and theoretically more robust to transient errors.

test/windows_test.go Outdated
ignoreTerminatedFields := cmpopts.IgnoreFields(corev1.ContainerStateTerminated{}, "StartedAt", "FinishedAt", "ContainerID")
ignoreStepFields := cmpopts.IgnoreFields(v1beta1.StepState{}, "ImageID")
if d := cmp.Diff(taskrun.Status.Steps, expectedStepState, ignoreTerminatedFields, ignoreStepFields); d != "" {
t.Fatalf("-got, +want: %v", d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tend to print these as -want,+got

test/windows_test.go Outdated
ignoreTerminatedFields := cmpopts.IgnoreFields(corev1.ContainerStateTerminated{}, "StartedAt", "FinishedAt", "ContainerID")
ignoreStepFields := cmpopts.IgnoreFields(v1beta1.StepState{}, "ImageID")
if d := cmp.Diff(taskrun.Status.Steps, expectedStepState, ignoreTerminatedFields, ignoreStepFields); d != "" {
t.Fatalf("-got, +want: %v", d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@aiden-deloryn
Update e2e tests for Windows and add docs
c02c238 
E2E tests for Windows have been updated based on review feedback.
Instructions for how to run Windows tests have also been added to
test/README.md
@aiden-deloryn
Copy link
Contributor Author

Thanks for the feedback, those changes have been added 🙂

@dibyom
Copy link
Member

dibyom commented Aug 11, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@imjasonh imjasonh mentioned this pull request Aug 11, 2021
Merged
5 tasks
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@tekton-robot tekton-robot merged commit 76cb481 into tektoncd:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@dibyom dibyom dibyom approved these changes

@jerop jerop Awaiting requested review from jerop

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@imjasonh imjasonh

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aiden-deloryn @tekton-robot @dibyom @imjasonh