-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume task not skipped if the run is associated #4583
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afrittoli @jerop @vdemeester my understanding was this is not possible 🙃 A
taskRun
orrun
is associated must have asucceeded
condition withunknown
i.e.running
status.We rely on the same check for the non-final tasks:
pipeline/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go
Line 207 in 4ad8f33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure about the root cause (my current assumption is a timing issue), but I think it makes sense to check if
Run
exists only and changeGetFinalTasks()
to use it instead ofIsSuccessful()
Whether it has a
Succeeded-type condition
or not, I think we can assume the task is scheduled since the reconciler found that it has associatedRun
.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pritidesai also thought that a
TaskRun
orRun
must have aConditionSucceeded
- but it looks like we don't initialize it when we create aTaskRun
in thePipelineRun
reconciler:pipeline/pkg/reconciler/pipelinerun/pipelinerun.go
Lines 722 to 777 in a343e75
Then we initialize
ConditionSucceeded
in theTaskRun
reconciler:pipeline/pkg/reconciler/taskrun/taskrun.go
Lines 99 to 100 in a343e75
If the above is correct, that a
TaskRun
orRun
can exist withoutConditionsSucceeded
, then it makes sense to either initializeConditionsSucceeded
toUnknown
increateTaskRun
/createRun
functions or check for existence ofTaskRun
orRun
instead ofConditionsSucceeded
which could be missingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerop thanks for the review! 🙂
I prefer checking the existence of
TaskRun
orRun
instead of initializingConditions
, since it is not possible to create resources with Status (as far as I know - please let me know if this is wrong 🙏 ) - which may cause this issue again since the reconciliation time is not guaranteed for the resources.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devholic makes sense to go with that option 👍🏾
cc @tektoncd/core-maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the
TaskRun
condition is set by theTaskRun
reconciler on the first reconciliation loop.In the
TaskRun
controller, at least within theReconcileKind
function, the condition will always be set as initialising the condition is the first thing we do inReconcileKind
.In the
PipelineRun
controller instead there is no guarantee. It may not be very likely to catch aTaskRun
with no condition set, but it is certainly possible and I guess it may happen more under high load.