Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8schain dep to avoid some log spam #4599

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

imjasonh
Copy link
Member

This should reduce some log spam stemming from the ecr-login credential
helper being used by k8schain, which previously would log a warning any
time it was asked to resolve creds for a non-ECR registry -- which we
regularly do...

go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to
replace them back to v0.22.5 to maintain compatibility with Knative
packages.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Reduce some spammy logs when resolving images not on ECR.

/assign @sbwsg
/assign @vdemeester
/assign @dlorenc

This should reduce some log spam stemming from the ecr-login credential
helper being used by k8schain, which previously would log a warning any
time it was asked to resolve creds for a non-ECR registry -- which we
regularly do...

go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to
replace them back to v0.22.5 to maintain compatibility with Knative
packages.
@imjasonh imjasonh requested review from vdemeester, dlorenc and a user February 18, 2022 19:52
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 18, 2022
@tekton-robot tekton-robot assigned ghost and vdemeester Feb 18, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2022
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@imjasonh
Copy link
Member Author

We should probably also bump pkg/authn/kubernetes to pick up google/go-containerregistry#1299 then cherrypick it into the release. @afrittoli

@dlorenc
Copy link
Contributor

dlorenc commented Feb 19, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2022
@imjasonh
Copy link
Member Author

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@tekton-robot tekton-robot merged commit 99b8b19 into tektoncd:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants