-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8schain dep to avoid some log spam #4599
Conversation
This should reduce some log spam stemming from the ecr-login credential helper being used by k8schain, which previously would log a warning any time it was asked to resolve creds for a non-ECR registry -- which we regularly do... go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to replace them back to v0.22.5 to maintain compatibility with Knative packages.
/test pull-tekton-pipeline-integration-tests |
We should probably also bump pkg/authn/kubernetes to pick up google/go-containerregistry#1299 then cherrypick it into the release. @afrittoli |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This should reduce some log spam stemming from the ecr-login credential
helper being used by k8schain, which previously would log a warning any
time it was asked to resolve creds for a non-ECR registry -- which we
regularly do...
go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to
replace them back to v0.22.5 to maintain compatibility with Knative
packages.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/assign @sbwsg
/assign @vdemeester
/assign @dlorenc