Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated #4612

Merged
merged 1 commit into from
Feb 23, 2022
Merged

TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated #4612

merged 1 commit into from
Feb 23, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Feb 23, 2022 •
edited
Loading

Changes

In TEP-0058: Graceful Termination, we deprecated PipelineRunCancelled and added:

  • StoppedRunFinally - To "stop" (i.e. let the tasks complete, then execute finally tasks) a Pipeline
  • CancelledRunFinally - To "cancel" (i.e. interrupt any executing non finally tasks, then execute finally tasks)
  • Cancelled - Same as today's PipelineRunCancelled - i.e. interrupt any executing tasks without running finally tasks

The above was released in v0.25 in June 2021.

This change adds the deprecated field - PipelineRunCancelled - to the deprecation table.

Issue: #4611
Pull Requests:

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Reminder that `PipelineRunCancelled` was deprecated in v0.25. Earliest removal date is March 2022.

@jerop
TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
abadc67 
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled`
and added:
- `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally
tasks) a Pipeline
- `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks,
then execute finally tasks)
- `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing
 tasks without running finally tasks

The above was released in [v0.25][v25] in June 2021.

This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table.

Issue: tektoncd#4611

[tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md
[v25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 23, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2022
@lbernick
Copy link
Member

/lgtm
Thanks Jerop!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@pritidesai
Copy link
Member

thank you @jerop, please add this announcement in the release notes 🙏

@jerop
Copy link
Member Author

jerop commented Feb 23, 2022 •
edited
Loading

@pritidesai it was already announced in v0.25, just not added to the deprecations table - do you think we need to announce again?

Edit: added a reminder in the release notes

@pritidesai
Copy link
Member

thank you @jerop, its my misunderstanding, I thought we are removing the flag in the next release (0.34 - March 2022). This is just an update the the deprecation table. When are we removing the flag then? with V1? or after promoting graceful termination to beta?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@tekton-robot tekton-robot merged commit 4a06c48 into tektoncd:main Feb 23, 2022
@jerop jerop deleted the tep-0058-deprecation branch June 11, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @lbernick @pritidesai @tekton-robot