Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Add Matrix Package #4934

Merged
merged 1 commit into from
Jun 3, 2022
Merged

TEP-0090: Add Matrix Package #4934

merged 1 commit into from
Jun 3, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 3, 2022 •
edited
Loading

Changes

TEP-0090 proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we add the matrix package which generates the combinations of the Parameters in a Matrix.

The types added are internal, and there are no user-facing changes in this PR.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 3, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2022
@jerop
Copy link
Member Author

jerop commented Jun 3, 2022

cc @pritidesai

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 0.0%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

lbernick
lbernick approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make it more clear in the commit message/PR description that these types are internal and won't be added to the API? i.e. no user facing changes

pkg/matrix/matrix_types.go Outdated Show resolved Hide resolved
@jerop jerop force-pushed the tep-0090-matrix-pkg branch 2 times, most recently from 209b70a to 1eff870 Compare June 3, 2022 15:13
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
abayer
abayer reviewed Jun 3, 2022
View reviewed changes
pkg/matrix/matrix.go Outdated Show resolved Hide resolved
@abayer
Copy link
Contributor

abayer commented Jun 3, 2022

/lgtm

pritidesai
pritidesai reviewed Jun 3, 2022
View reviewed changes
pkg/matrix/matrix.go Outdated Show resolved Hide resolved
@jerop
Copy link
Member Author

jerop commented Jun 3, 2022

/test pull-tekton-pipeline-integration-tests

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@jerop
Copy link
Member Author

jerop commented Jun 3, 2022

2022/06/03 16:10:27 main.go:319: Something went wrong: failed to prepare test environment: --provider=gke boskos failed to acquire project: resources not found 😕

/test pull-tekton-pipeline-integration-tests

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@jerop jerop force-pushed the tep-0090-matrix-pkg branch 2 times, most recently from 73c1474 to 721e517 Compare June 3, 2022 17:23
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@jerop
TEP-0090: Add Matrix Package
9387e73 
[TEP-0090][tep-0090] proposed executing a `PipelineTask` in parallel
`TaskRuns` and `Runs` with substitutions from combinations of `Parameters`
in a `Matrix`.

In this change, we add the matrix package which generates the combinations
of the `Parameters` in a `Matrix`.

The types added are internal, and there are no user-facing changes in this PR.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/matrix/matrix.go Do not exist 100.0%
pkg/matrix/matrix_types.go Do not exist 100.0%

@abayer
Copy link
Contributor

abayer commented Jun 3, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@tekton-robot tekton-robot merged commit 2f83789 into tektoncd:main Jun 3, 2022
@jerop jerop deleted the tep-0090-matrix-pkg branch June 11, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer left review comments

@pritidesai pritidesai pritidesai left review comments

@lbernick lbernick lbernick approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jerop @tekton-robot @abayer @pritidesai @lbernick