TEP-0090: Refactor GetChildReferences #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
/lgtm Much less ugly than my original effort! =) |
|
The following is the coverage report on the affected files.
|
pritidesai
reviewed
Jun 3, 2022
pritidesai
reviewed
Jun 3, 2022
pritidesai
reviewed
Jun 3, 2022
pritidesai
reviewed
Jun 3, 2022
pritidesai
reviewed
Jun 3, 2022
pritidesai
reviewed
Jun 3, 2022
In this change, we separate that logic to fetch the childRef of a specific TaskRun from the function that gets the childRefs for all TaskRuns in the PipelineRunState. This is separate function is helpful for reuse and readability. No functional changes made in this commit.
jerop
force-pushed
the
tep-0090-refactor-getchildrefs
branch
from
ad68e80
to
86106a2
Compare
tekton-robot
added
size/M
|
The following is the coverage report on the affected files.
|
|
@abayer @pritidesai - thank you for the reviews, this PR is ready for another look (cc @lbernick) |
lbernick
approved these changes
Jun 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this change, we separate that logic to fetch the childRef of a
specific TaskRun from the function that gets the childRefs for all
TaskRuns in the PipelineRunState. This is separate function is
helpful for reuse and readability.
No functional changes made in this commit.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes