-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0090: Refactor GetChildReferences #4940
TEP-0090: Refactor GetChildReferences #4940
Conversation
/lgtm Much less ugly than my original effort! =) |
The following is the coverage report on the affected files.
|
In this change, we separate that logic to fetch the childRef of a specific TaskRun from the function that gets the childRefs for all TaskRuns in the PipelineRunState. This is separate function is helpful for reuse and readability. No functional changes made in this commit.
ad68e80
to
86106a2
Compare
The following is the coverage report on the affected files.
|
@abayer @pritidesai - thank you for the reviews, this PR is ready for another look (cc @lbernick) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
In this change, we separate that logic to fetch the childRef of a
specific TaskRun from the function that gets the childRefs for all
TaskRuns in the PipelineRunState. This is separate function is
helpful for reuse and readability.
No functional changes made in this commit.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes