-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0090: Add details to isFailure
docstring
#4970
Conversation
In this change, we add details to `isFailure` to address how it handles `Matrix`. We also remove the the inline comment that may be confusing.
cc @lbernick |
/test pull-tekton-pipeline-alpha-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-tekton-pipeline-alpha-integration-tests |
isFailure
docstringisFailure
docstring
Changes
In this change, we add details to
isFailure
to address how it handlesMatrix
. We also remove the the inline comment that may be confusing./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes