TEP-0090: Test isSuccessful
#4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
`isSuccessful` is an unexported function, so it did not have tests per the in [guidelines][guidelines]. The recommendation is to not test unexported function, and if needed to move the function into a package, test it then export the function. However, this is hard to do for the resources package because of cyclic dependencies. We already have tests for another unexported function - `isFailure` - and discussions to make exceptions for that guideline are ongoing. In this change, we add tests for `isSuccessful` to ensure it works as expected, as we prepare to make changes to the function to support `Matrix`. [guidelines]: https://github.com/tektoncd/community/blob/ac0ae1b304ef515e8099f772f42b91aac1b26e6b/standards.md#tests
|
/test pull-tekton-pipeline-go-coverage |
1 similar comment
|
/test pull-tekton-pipeline-go-coverage |
|
/lgtm |
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/assign |
dibyom
approved these changes
Jun 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isSuccessfulis an unexported function, so it did not have testsper the in guidelines. The recommendation is to not
test unexported function, and if needed to move the function into
a package, test it then export the function. However, this is hard
to do for the resources package because of cyclic dependencies. We
already have tests for another unexported function -
isFailure-and discussions to make exceptions for that guideline are ongoing.
In this change, we add tests for
isSuccessfulto ensure it worksas expected, as we prepare to make changes to the function to support
Matrix./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes