Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the release-note-none to dependabot #4997

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Jun 17, 2022

Changes

Without the release label, dependabot PRs cannot be merged.
Altering the PR to add the label means that dependabot won't
be able to manage its PR anymore, so adding the release note
label by default.

Signed-off-by: Andrea Frittoli [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

Without the release label, dependabot PRs cannot be merged.
Altering the PR to add the label means that dependabot won't
be able to manage its PR anymore, so adding the release note
label by default.

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2022
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 17, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@pritidesai
Copy link
Member

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@afrittoli
Copy link
Member Author

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

That would be in the PR description created by dependabot, or are you thinking of some other place we should document it?
We could include it in the release notes but we've not done it until now.

@pritidesai
Copy link
Member

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

That would be in the PR description created by dependabot, or are you thinking of some other place we should document it? We could include it in the release notes but we've not done it until now.

Thanks @afrittoli

Yeah I was thinking of including it in the release notes.

So the dependabot PRs has the details in the PR title that its upgrading a package from one version to the other. If we can automatically capture the same details in the PR release notes such that the release manager (task) can list them in a separate section when creating a release.

@tekton-robot tekton-robot merged commit 6c2ffa4 into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants