Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr.io/distroless/static as base image #5009

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jun 21, 2022

This also updates the Windows nanoserver base image used by the
entrypoint image.

/kind misc

Changes

The ghcr-distroless image is slightly smaller, and somewhat more well maintained than the gcr-distroless image at this time. Since the image contains almost nothing to begin with, there are no expected behavior changes expected as part of this upgrade.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Images are based on ghcr.io/distroless/static, and the entrypoint image is updated to use nanoserver:ltsc2022 instead of :1809

This also updates the Windows nanoserver base image used by the
entrypoint image, and updates the Go version used to build the combine
command to the latest Go release 1.18.3.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2022
@tekton-robot tekton-robot requested a review from dibyom June 21, 2022 18:42
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2022
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

tekton/publish.yaml Outdated Show resolved Hide resolved
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

1 similar comment
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@imjasonh
Copy link
Member Author

Just a heads up that ghcr.io/distroless/static is on track to become ko's new default base image (ko-build/ko#737), so any issues we might hit will be instructive in how we push that forward.

I don't expect any issues, but I'll also be on the lookout for anything suspicious. 👀

@tekton-robot tekton-robot merged commit 9da5778 into tektoncd:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants