Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0090: Update PipelineRun Status from Child Refs #5014

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 22, 2022

Changes

Prior to this change, the function that ensures that PipelineRun
status stays in sync with actual TaskRuns and Runs used a map
whose key was a PipelineTask name and value was a ChildReference.

In this change, we modify the key to be the TaskRun or Run names.
This allows us to handle matrixed scenarios, where one PipelineTask
has multiple TaskRuns and Runs - hence multiple ChildReferences.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

Prior to this change, the function that ensures that PipelineRun
status stays in sync with actual TaskRuns and Runs used a map
whose key was a PipelineTask name and value was a ChildReference.

In this change, we modify the key to be the TaskRun or Run names.
This allows us to handle matrixed scenarios, where one PipelineTask
has multiple TaskRuns and Runs - hence multiple ChildReferences.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/test pull-tekton-pipeline-go-coverage

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

@abayer @dibyom please take a look

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

2022/06/22 12:22:41 error during command execution:error processing import paths in "config/controller.yaml": error resolving image references: GET https://ghcr.io/v2/distroless/git/blobs/sha256:b748c8dabf76ef2c95cfe177cd9c0a9d767fbe58efa8843039d94e89308c4681: UNAUTHORIZED: unauthenticated: User cannot be authenticated with the token provided.

is it a flake?

/test pull-tekton-pipeline-build-tests

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

5 similar comments
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@tekton-robot tekton-robot merged commit 1d3d9ad into tektoncd:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants