Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: GetChildReferences checks for non-nil TaskRuns #5016

Merged
merged 1 commit into from
Jun 22, 2022
Merged

TEP-0090: GetChildReferences checks for non-nil TaskRuns #5016

merged 1 commit into from
Jun 22, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 22, 2022

Changes

In #5006, we refactored GetChildReferences such that it checks that TaskRun is non-nil before calling the helper function getChildRefForTaskRun that expects a non-nil TaskRun.

In this change, we add a check that each TaskRun from matrixed PipelineTask is non-nil before calling getChildRefForTaskRun.

Related PR: #5008

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@jerop
GetChildReferences checks for non-nil TaskRuns
492928e 
In tektoncd#5006, we refactored
`GetChildReferences` such that it checks that `TaskRun` is non-nil
before calling the helper function `getChildRefForTaskRun` that
expects a non-nil `TaskRun`.

In this change, we add a check that each `TaskRun` from matrixed
`PipelineTask` is non-nil before calling `getChildRefForTaskRun`.

Related PR: tektoncd#5008
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.3% 0.0

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

@abayer @dibyom please take a look

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

2022/06/22 12:22:41 error during command execution:error processing import paths in "config/controller.yaml": error resolving image references: GET https://ghcr.io/v2/distroless/git/blobs/sha256:b748c8dabf76ef2c95cfe177cd9c0a9d767fbe58efa8843039d94e89308c4681: UNAUTHORIZED: unauthenticated: User cannot be authenticated with the token provided.

is it a flake?

/test pull-tekton-pipeline-build-tests

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/test pull-tekton-pipeline-integration-tests

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/retest

1 similar comment
@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@jerop
Copy link
Member Author

jerop commented Jun 22, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/retest

@tekton-robot tekton-robot merged commit 881510f into tektoncd:main Jun 22, 2022
@jerop jerop changed the title GetChildReferences checks for non-nil TaskRuns TEP-0090: GetChildReferences checks for non-nil TaskRuns Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @vdemeester