Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused arguments - mostly removing unused ctx 🧹 #5028

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 23, 2022

Changes

In this change, we cleanup unused arguments in functions, mostly removing unused "ctx".

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

In this change, we cleanup unused arguments in functions, mostly
removing unused "ctx".
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2022
@jerop
Copy link
Member Author

jerop commented Jun 23, 2022

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 23, 2022
@abayer
Copy link
Contributor

abayer commented Jun 23, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason it exists on SetDefaults for example, is to make is Defaultable. This is not necessary useful for non CRD types though, but I tend to like the consistency. But.. I also do not like when there is function param that are not used 😛

@jerop
Copy link
Member Author

jerop commented Jun 23, 2022

The main reason it exists on SetDefaults for example, is to make is Defaultable. This is not necessary useful for non CRD types though, but I tend to like the consistency. But.. I also do not like when there is function param that are not used 😛

@vdemeester SetDefaults still has context.Context - it's just that it's not named because it's not used -- did the same thing for Validate to make it Validatable

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@tekton-robot tekton-robot merged commit 5663279 into tektoncd:main Jun 23, 2022
@jerop jerop deleted the remove-ctx branch June 23, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants