Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Support both matrix and params in a PipelineTask #5050

Merged
merged 1 commit into from
Jun 29, 2022
Merged

TEP-0090: Support both matrix and params in a PipelineTask #5050

merged 1 commit into from
Jun 29, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 29, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

This change implements the fan out of PipelineTasks that have both matrix and params specified. The matrix is used to fan out the PipelineTask and the params are the same in all the TaskRuns.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

Users can specify both `matrix` and `params` fields. The `matrix` is used to fan out the `PipelineTask` and the `params` are the same in all the `TaskRuns`.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 29, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.3% -0.0

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 29, 2022
@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

cc @abayer @dibyom @lbernick please take a look

@jerop jerop force-pushed the tep-0090-matrix-and-params branch from 450a026 to 483bd9c Compare June 29, 2022 12:08
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.3% -0.0

@jerop jerop force-pushed the tep-0090-matrix-and-params branch from 483bd9c to 29eb6b5 Compare June 29, 2022 12:34
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.3% -0.0

abayer
abayer approved these changes Jun 29, 2022
View reviewed changes
pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@jerop
TEP-0090: Support both matrix and params in a PipelineTask
28cf960 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

This change implements the fan out of `PipelineTasks` that have both
`matrix` and `params` specified. The `matrix` is used to fan out the
`PipelineTask` and the `params` are the same in all the `TaskRuns`.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-matrix-and-params branch from 29eb6b5 to 28cf960 Compare June 29, 2022 15:14
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2022
@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/test check-pr-has-kind-label

@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.2% -0.0

@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/test pull-tekton-pipeline-integration-tests

pod pending timeout

@abayer
Copy link
Contributor

abayer commented Jun 29, 2022

/test pull-tekton-pipeline-integration-tests

Job hung. =)

@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

thanks @abayer 😀

@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/test pull-tekton-pipeline-integration-tests

2 similar comments
@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/test pull-tekton-pipeline-integration-tests

@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit df074f2 into tektoncd:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @lbernick @abayer