-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move API version validation into separate package #5053
Conversation
03f3a51
to
6850d27
Compare
This commit moves version validation out of the v1beta1 package into its own package. This code isn't part of the v1beta1 API, and contains utilities that will be needed for the v1 API as well. No functional changes.
The following is the coverage report on the affected files.
|
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test pull-tekton-pipeline-alpha-integration-tests |
The following is the coverage report on the affected files.
|
Changes
This commit moves version validation out of the v1beta1 package into
its own package. This code isn't part of the v1beta1 API, and contains
utilities that will be needed for the v1 API as well. No functional changes.
Part 1 of #4983.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes