Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move API version validation into separate package #5053

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Move API version validation into separate package #5053

merged 1 commit into from
Jun 30, 2022

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jun 29, 2022 •
edited
Loading

Changes

This commit moves version validation out of the v1beta1 package into
its own package. This code isn't part of the v1beta1 API, and contains
utilities that will be needed for the v1 API as well. No functional changes.

Part 1 of #4983.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 29, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2022
@lbernick lbernick force-pushed the version branch 2 times, most recently from 03f3a51 to 6850d27 Compare June 29, 2022 16:42
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2022
@lbernick
Move API version validation into separate package
ed62568 
This commit moves version validation out of the v1beta1 package into
its own package. This code isn't part of the v1beta1 API, and contains
utilities that will be needed for the v1 API as well. No functional changes.
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/version/version_validation.go Do not exist 100.0%

@abayer
Copy link
Contributor

abayer commented Jun 29, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@dibyom
Copy link
Member

dibyom commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@lbernick
Copy link
Member Author

/retest

3 similar comments
@lbernick
Copy link
Member Author

/retest

@lbernick
Copy link
Member Author

/retest

@lbernick
Copy link
Member Author

/retest

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests

@dibyom dibyom closed this Jun 30, 2022
@dibyom dibyom reopened this Jun 30, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/version/version_validation.go Do not exist 100.0%

@tekton-robot tekton-robot merged commit eca056e into tektoncd:main Jun 30, 2022
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Jul 4, 2022
@JeromeJu
update validation according to tektoncd#5053
dc35e0b
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Jul 7, 2022
@JeromeJu
update validation according to tektoncd#5053
dc0eafe
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Jul 8, 2022
@JeromeJu
update validation according to tektoncd#5053
c6ef5d5
@lbernick lbernick deleted the version branch August 12, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pritidesai pritidesai

@dibyom dibyom

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbernick @tekton-robot @abayer @dibyom @pritidesai @jerop