Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add almost-empty v1 package #5055

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Add almost-empty v1 package #5055

merged 1 commit into from
Jul 11, 2022

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jun 29, 2022

Changes

This commit adds a package for v1 and updates the hack directory to generate
code and OpenAPI spec for v1. The v1 package is left as minimal as possible;
however, the code does not build and pass tests without at least one generated client.
Therefore, a Task type is added with only a Description field, with the rest of the
Task spec to be added in a future commit.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 29, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 29, 2022
@lbernick lbernick marked this pull request as draft June 29, 2022 19:00
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 30, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@dibyom dibyom removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@dibyom
Copy link
Member

dibyom commented Jun 30, 2022

/retest

@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2022
@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

blocked on #5066

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@lbernick lbernick marked this pull request as ready for review July 7, 2022 18:58
@tekton-robot tekton-robot requested a review from dlorenc July 7, 2022 18:58
@lbernick lbernick changed the title Add empty v1 package Add almost-empty v1 package Jul 7, 2022
This commit adds a package for v1 and updates the hack directory to generate
code and OpenAPI spec for v1. The v1 package is left as minimal as possible;
however, the code does not build and pass tests without at least one generated client.
Therefore, a Task type is added with only a Description field, with the rest of the
Task spec to be added in a future commit.
@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@ywluogg
Copy link
Contributor

ywluogg commented Jul 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@abayer
Copy link
Contributor

abayer commented Jul 11, 2022

Looks good in general, though I'm inherently a bit wary of adding a v1 api without it being fully populated. But it should be harmless, I guess?

Would like to get thoughts from others from @tektoncd/core-maintainers

@vdemeester
Copy link
Member

Looks good in general, though I'm inherently a bit wary of adding a v1 api without it being fully populated. But it should be harmless, I guess?

Would like to get thoughts from others from @tektoncd/core-maintainers

@abayer this is just the code and the package, it is not exported or exposed in any way. This is what we did for v1beta1.
I think it's fine, except maybe the openapi/swagger generation 👼🏼

@abayer
Copy link
Contributor

abayer commented Jul 11, 2022

Looks good in general, though I'm inherently a bit wary of adding a v1 api without it being fully populated. But it should be harmless, I guess?
Would like to get thoughts from others from @tektoncd/core-maintainers

@abayer this is just the code and the package, it is not exported or exposed in any way. This is what we did for v1beta1. I think it's fine, except maybe the openapi/swagger generation 👼🏼

@lbernick handled that bit nicely - generating v1beta1 and v1 OpenAPI and swagger separately from each other. So given that, I think this is good to go. =)

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@lbernick
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 25b8965 into tektoncd:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants