Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Matrix - implement isRunning for Runs #5062

Merged
merged 1 commit into from
Jul 1, 2022
Merged

TEP-0090: Matrix - implement isRunning for Runs #5062

merged 1 commit into from
Jul 1, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 30, 2022

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we implement the isRunning member function of ResolvedPipelineTask when the PipelineTask has a Custom Task. If the ResolvedPipelineTask is matrixed and is custom task, it is running if any of its Runs are not completed.

Related PR: #4981

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@jerop
TEP-0090: Matrix - implement isRunning for Runs
9d38d07 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

In this change, we implement the `isRunning` member function of
`ResolvedPipelineTask` when the `PipelineTask` has a `Custom Task`.

 If the `ResolvedPipelineTask` is matrixed and is custom task, it is
 running if any of its `Runs` are not completed.

Related PR: tektoncd#4981

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 30, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@tekton-robot tekton-robot requested a review from abayer June 30, 2022 15:18
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2022
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

cc @abayer @dibyom @lbernick please take a look

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 30, 2022
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

@jerop: No presubmit jobs available for tektoncd/pipeline@main

In response to this:

/test pull-tekton-pipeline-alpha-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.3% 0.0

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop jerop mentioned this pull request Jun 30, 2022
Merged
4 tasks
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/retest

1 similar comment
@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

1 similar comment
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/retest

@jerop jerop closed this Jun 30, 2022
@jerop jerop reopened this Jun 30, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.3% 0.0

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

CloudEvents

/test tekton-pipeline-unit-tests

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-tekton-pipeline-build-tests

1 similar comment
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-tekton-pipeline-build-tests

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/retest

@jerop
Copy link
Member Author

jerop commented Jul 1, 2022

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 83485c0 into tektoncd:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

@abayer abayer Awaiting requested review from abayer

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @lbernick