-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V1 Task Golang structs #5125
Conversation
3bde81a
to
6f80d5f
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This commit adds structs and validation for v1 Task, including results, params, and workspaces. Because we do not yet serve a v1 version of the Task CRD, this change should have no impact. This is copied from v1beta1 with the following exceptions: - omitted PipelineResources - removed deprecated Step and StepTemplate fields - did not copy over Task interface (TaskObject) as ClusterTask is not (yet?) moving to V1
The following is the coverage report on the affected files.
|
@tektoncd/core-maintainers PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
This commit adds structs and validation for v1 Task, including results,
params, and workspaces. Because we do not yet serve a v1 version of the Task
CRD, this change should have no impact. This is copied from v1beta1 with the following
exceptions:
Part of #4984.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes