-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Tekton controller panic for Metrics #5166
Conversation
Trying to test this fix. |
The following is the coverage report on the affected files.
|
/kind bug |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @khrm Do we have any tests for the metrics recording which might help catch this sort of bug early? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dibyom We don't have any such tests for metrics. Or even e2e tests. We do have an outstanding issue regarding this.
If taskrun/pipelinerun completion is watch by another program and deleted as soon as it is done, then metrics won't be able to fetch it and should return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abayer Can we get this merged? @afrittoli @dibyom
/lgtm |
logger.Errorf("Error getting PipelineRun %s when updating metrics: %w", pr.Name, err) | ||
return | ||
} else if kerrors.IsNotFound(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If err IsNotFound, newPr is nil, thus L257 panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Will you raise a new pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you didn't raise a pr, I am creating one for taskrun/pipelinerun referencing you.
If taskrun/pipelinerun completion is watch by another program
and deleted as soon as it is done, then metrics won't be able to
fetch it and should return.
Fixes #5165
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes