Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Matrix - Retries #5305

Merged
merged 1 commit into from
Aug 12, 2022
Merged

TEP-0090: Matrix - Retries #5305

merged 1 commit into from
Aug 12, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Aug 10, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

Today, a matrixed PipelineTask that has retries will reattempt each matrixed TaskRun when one of them fails. In this change, we fix this issue such that each retry is completed for each matrixed TaskRun. That is, each retry for each TaskRun is completed before it is reattempted; failure in one matrixed TaskRun no longer affects retries for other matrixed TaskRuns from the same PipelineTask.

Many thanks to @AlanGreene for catching this issue!

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Each retry for each matrixed `TaskRun` is completed before it is reattempted; failure in one matrixed `TaskRun` no longer affects retries for other matrixed `TaskRuns` from the same `PipelineTask`.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 10, 2022
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.7% 85.8% 0.0

@jerop jerop added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2022
@jerop
Copy link
Member Author

jerop commented Aug 10, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Aug 10, 2022

/assign

@jerop jerop marked this pull request as draft August 10, 2022 19:06
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@jerop jerop marked this pull request as ready for review August 11, 2022 15:06
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.7% 85.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.7% 85.8% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.7% 85.8% 0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@jerop
TEP-0090: Matrix - Retries
0ea2535 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

Today, a matrixed `PipelineTask` that has retries will reattempt each
matrixed `TaskRun` when one of them fails. In this change, we fix this
issue such that each retry is completed for each matrixed `TaskRun`.
That is, each retry for each `TaskRun` is completed before it is
reattempted; failure in one matrixed `TaskRun` no longer affects retries
for other matrixed `TaskRuns` from the same `PipelineTask`.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 85.7% 85.8% 0.0

@abayer
Copy link
Contributor

abayer commented Aug 12, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2022
@tekton-robot tekton-robot merged commit 4aa2379 into tektoncd:main Aug 12, 2022
@jerop jerop deleted the tep-0090-retries branch August 12, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@abayer abayer Awaiting requested review from abayer

@dlorenc dlorenc Awaiting requested review from dlorenc

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @lbernick