-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment tests in v1 task_validation_test.go #5323
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this PR! I also feel confused when working on ArrayOrString renaming. #5304
Do you mind rebasing from main and renaming NewArrayOrString method? It is also renamed
This commit uncomments tests that were accidentally commented out. No functional changes.
Done
I don't see this in v1? |
Yeah in V1 we don't have NewArrayOrString as you suggested, no need to keep it back-compatible |
/lgtm |
Changes
This commit uncomments tests that were accidentally commented out.
No functional changes.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes