Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change ghcr.io/distroless/* to distroless.dev/* #5341

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Aug 18, 2022

At this time, distroless.dev/static simply redirects to
ghcr.io/distroless/static, so this is effectively no change.

However, we are evaluating renaming the github.com/distroless org to
avoid confusion, and in doing so, images at ghcr.io/distroless may be
disrupted. Using the distroless.dev redirector gives us flexibility to
change the underlying image registry transparently.

The redirector code for distroless.dev is open source at
https://github.com/chainguard-dev/registry-redirect and we've used it
extensively internally for a month or two with no serious issues.

Any credentials that are used are not logged or stored by the
redirector, and since the image in question is public anyway, any
credentials that pass through the redirector have no elevated
permissions.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Images are based on distroless.dev/* instead of the (equivalent) ghcr.io/distroless/* -- no effective behavior change

PR friction log:

  • release-note space shenanigans ❌
  • TestPipelineRunTimeout failed on integration tests and alpha integration tests, retried ❌

At this time, distroless.dev/static simply redirects to
ghcr.io/distroless/static, so this is effectively no change.

However, we are evaluating renaming the github.com/distroless org to
avoid confusion, and in doing so, images at ghcr.io/distroless may be
disrupted. Using the distroless.dev redirector gives us flexibility to
change the underlying image registry transparently.

The redirector code for distroless.dev is open source at
https://github.com/chainguard-dev/registry-redirect and we've used it
extensively internally for a month or two with no serious issues.

Any credentials that are used are not logged or stored by the
redirector, and since the image in question is public anyway, any
credentials that pass through the redirector have no elevated
permissions.
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2022
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@abayer
Copy link
Contributor

abayer commented Aug 19, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@tekton-robot tekton-robot merged commit 12681b6 into tektoncd:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants