Add baseimage for windows 1809 to support AKS

[Transmitt0r]

Changes

Add nanoserver:1809 to combined baseimage, bause aks windows nodepools use the akswindows2019 SKU with the 1809 Kernel. This allows AKS users to run tekton tasks on windows nodepools.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Transmitt0r / name: Lukas Grotz (ca40288)

[tekton-robot]

Hi @Transmitt0r. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Transmitt0r]

/kind feature

[imjasonh]

This fails when I run it myself using combine:

$ go run ./vendor/github.com/tektoncd/plumbing/cmd/combine/main.go \
        distroless.dev/static \
        mcr.microsoft.com/windows/nanoserver:1809 \
        mcr.microsoft.com/windows/nanoserver:ltsc2019 \
        mcr.microsoft.com/windows/nanoserver:ltsc2022 \
        gcr.io/jason-chainguard/combined
...
2022/08/24 09:51:35 --- mcr.microsoft.com/windows/nanoserver:1809 ---
2022/08/24 09:51:35 found platform {Architecture:amd64 OS:windows OSVersion:10.0.17763.3287 OSFeatures:[] Variant: Features:[]}
2022/08/24 09:51:35 --- mcr.microsoft.com/windows/nanoserver:ltsc2022 ---
2022/08/24 09:51:35 found platform {Architecture:amd64 OS:windows OSVersion:10.0.20348.887 OSFeatures:[] Variant: Features:[]}
2022/08/24 09:51:36 --- mcr.microsoft.com/windows/nanoserver:ltsc2019 ---
2022/08/24 09:51:36 adding manifests from src "mcr.microsoft.com/windows/nanoserver:ltsc2019": conflicting platform {Architecture:amd64 OS:windows OSVersion:10.0.17763.3287 OSFeatures:[] Variant: Features:[]}
exit status 1

This error indicates that the nanoserver:ltsc2019 image provides the same platform, including OS version, as nanoserver:1809, and the tool refuses to produce a manifest with two identical platforms.

Can you elaborate on how :1809 and :ltsc2019 are different, and why :1809 is also needed? It's possible that :ltsc2019 should be removed in favor of :1809, as it was only recently added in #5333

[imjasonh]

In fact, it looks like the manifests for :1809 and :ltsc2019 are identical, using crane.

diff <(crane manifest mcr.microsoft.com/windows/nanoserver:1809) <(crane manifest mcr.microsoft.com/windows/nanoserver:ltsc2019)

Are these just two tags for the same underlying image?

[abayer]

/ok-to-test

[Transmitt0r]

Actually I'm not that sure now that you say it. Is the change with ltsc2019 in the v0.39.0 release? I saw #5333 and thought that was already in the release but I can't see the entry in the manifest.

[imjasonh]

Actually I'm not that sure now that you say it. Is the change with ltsc2019 in the v0.39.0 release? I saw #5333 and thought that was already in the release but I can't see the entry in the manifest.

It looks like the change in #5333 might not have been applied to the release pipeline before v0.39.0 was cut and the pipeline run. I'll check with release managers to see if that's the case.

[vdemeester]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

/lgtm

[imjasonh]

FWIW this change isn't actually necessary, and should cause combine to fail since mcr.microsoft.com/windows/nanoserver:1809 and mcr.microsoft.com/windows/nanoserver:ltsc2019 are identical, and both provide the same platform:

{
        "architecture": "amd64",
        "os": "windows",
        "os.version": "10.0.17763.3406"
}

Sorry for not closing this earlier. If this causes combine to fail during nightly tests, we should revert this.

[abayer]

Well, bugger. Failed for me locally too - let's revert now.

[abayer]

#5502 reverts this.

[Transmitt0r]

Ok thanks, 2019 LTSC works fine on aks Windows nodes too btw 🎉