-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseimage for windows 1809 to support AKS #5361
Conversation
|
Hi @Transmitt0r. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
ca40288
to
f0ff6fe
Compare
Prior to this example it was not possible to easily use tekton on AKS with a windows nodepool. Adding nanoserver:1809 with OS Version 10.0.17763.3287 allows nodes running windows 1809 to be used for task execution.
This fails when I run it myself using
This error indicates that the Can you elaborate on how |
In fact, it looks like the manifests for
Are these just two tags for the same underlying image? |
/ok-to-test |
Actually I'm not that sure now that you say it. Is the change with ltsc2019 in the v0.39.0 release? I saw #5333 and thought that was already in the release but I can't see the entry in the manifest. |
It looks like the change in #5333 might not have been applied to the release pipeline before v0.39.0 was cut and the pipeline run. I'll check with release managers to see if that's the case. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
FWIW this change isn't actually necessary, and should cause
Sorry for not closing this earlier. If this causes |
Well, bugger. Failed for me locally too - let's revert now. |
#5502 reverts this. |
Ok thanks, 2019 LTSC works fine on aks Windows nodes too btw 🎉 |
Changes
Add nanoserver:1809 to combined baseimage, bause aks windows nodepools use the akswindows2019 SKU with the 1809 Kernel. This allows AKS users to run tekton tasks on windows nodepools.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes