Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Updating runs.md Documentation #5390

Closed
wants to merge 1 commit into from
Closed

Conversation

vsinghai
Copy link
Contributor

Changes

Prior to this commit, the previous iteration
of the runs.md doc had some fields missing from
the API and the level of detail and clarification.

In this commit, we aim to clarify the API and update
it to make sure it is clear, upto date, and has useful
examples.

Fixes issue #5158

/cc @jerop
/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Prior to this commit, the previous iteration
of the runs.md doc had some fields missing from
the API and the level of detail and clarification.

In this commit, we aim to clarify the API and update
it to make sure it is clear, upto date, and has useful
examples.

Fixes issue [tektoncd#5158](tektoncd#5158)

/cc @jerop
/kind documentation
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Aug 29, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jerop after the PR has been reviewed.
You can assign the PR to them by writing /assign @jerop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

Hi @vsinghai. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2022
@vsinghai
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022
@lbernick
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2022
@lbernick lbernick self-assigned this Aug 29, 2022
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Varun! This is great to have, but I don't think we should close #5158 when this is merged (I think "fixes #" in your PR description will result in that happening).

I think there's a lot more documentation for runs that would be nice to have, such as realistic examples of ci/cd pipelines containing runs and links to useful existing custom tasks. @jerop maybe worth updating the issue with some ideas, and possibly @geriom you might have some thoughts here as well? Might be out of scope for this PR-- I can see in the PR description you're planning to add some examples?

@@ -54,12 +54,16 @@ A `Run` definition supports the following fields:
- Optional:
- [`params`](#specifying-parameters) - Specifies the desired execution
parameters for the custom task.
- [`status`](#) - Used for cancelling a `Run`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few of these links are broken.

@@ -54,12 +54,16 @@ A `Run` definition supports the following fields:
- Optional:
- [`params`](#specifying-parameters) - Specifies the desired execution
parameters for the custom task.
- [`status`](#) - Used for cancelling a `Run`.
- [`statusMessage`](#) - Status message for cancellation.
- [`retries`](#) - Specifies propagating retries count to custom tasks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [`retries`](#) - Specifies propagating retries count to custom tasks.
- [`retries`](#) - Specifies the number of times the `Run` should retry, if the custom task controller supports retries.

@vsinghai
Copy link
Contributor Author

vsinghai commented Aug 30, 2022

Thanks for the feedback @lbernick! There is still currently a lot that I have left to do for this PR, including (but not limited to) having examples for the custom fields and providing more clarity to the API. The reason I created a PR was so that @jerop can just look over the incremental progress that I am making to make sure we are on the same path regarding how to fix #5158, and is also why I have the PR on hold. I apologize for the confusion.

@lbernick
Copy link
Member

no problem, thanks for the explanation! I think creating a draft PR can be useful in situations like these- it lets reviewers know that it's still a WIP (hold does this to some extent but I wasn't sure why the PR was on hold)

@vsinghai vsinghai marked this pull request as draft August 30, 2022 14:16
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@jerop jerop self-assigned this Sep 6, 2022
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2022
@jerop jerop closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants