-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the remote resolvers deployment to a separate namespace #5436
Move the remote resolvers deployment to a separate namespace #5436
Conversation
/assign @vdemeester |
The following is the coverage report on the affected files.
|
db1ed6a
to
2f1a78c
Compare
The following is the coverage report on the affected files.
|
2f1a78c
to
dbb7cd8
Compare
The following is the coverage report on the affected files.
|
In https://github.com/tektoncd/community/blob/main/teps/0060-remote-resource-resolution.md#3-create-a-new-tekton-resolution-project, we say: ``` Webhook and controller deployments for ResolutionRequest objects will run in the tekton-remote-resolution namespace by default. The namespace is intentionally separate from tekton-pipelines to allow RBAC that isolates the remote resolution machinery. ``` While the actual `ResolutionRequest` reconciler/webhooks/etc are now part of the core Pipeline controller/webhook deployments, the actual resolvers (i.e., `git`, `hub`, `bundles`) should probably still be moved to a separate namespace from `tekton-pipelines` to properly isolate the actual resolver executions. So let's do that. Signed-off-by: Andrew Bayer <[email protected]>
dbb7cd8
to
d02afeb
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes
In https://github.com/tektoncd/community/blob/main/teps/0060-remote-resource-resolution.md#3-create-a-new-tekton-resolution-project, we say:
While the actual
ResolutionRequest
reconciler/webhooks/etc are now part of the core Pipeline controller/webhook deployments, the actual resolvers (i.e.,git
,hub
,bundles
) should probably still be moved to a separate namespace fromtekton-pipelines
to properly isolate the actual resolver executions. So let's do that.Note that no release note is needed, because this should be merged in before the first Pipeline release with remote resolution incorporated into it.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes